Draft
Conversation
AntoineGautier
force-pushed
the
issue1374_template_CHW_final
branch
from
e9d8537 to
63fd529
Compare
Contributor
Author
|
The current branch Solving this issue requires refactoring the implementation of the SOO in Therefore, the branch |
AntoineGautier
changed the title
AntoineGautier
force-pushed
the
issue1374_template_CHW_final
branch
2 times, most recently
from
2e56df8 to
737165e
Compare
AntoineGautier
force-pushed
the
issue1374_template_CHW_final
branch
from
f495ab8 to
68d8084
Compare
- The description of the parameters for the design CHW/HW and source temperature has been updated. - The documentation of the core block has been improved. - The parameter P_min is now declared as SI.Power. - The input connector TSet has been moved to avoid overlap with ySet. - The description of the input connectors on, hea and coo has been clarified.
…/modelica-buildings into issue4152_HpTemplateWithModular
- Replace source by ambient for compatibility with cooling cycles.
…/modelica-buildings [ci skip]
AntoineGautier
force-pushed
the
issue1374_template_CHW_final
branch
from
72bec51 to
9234486
Compare
AntoineGautier
force-pushed
the
issue1374_template_CHW_final
branch
from
9234486 to
c8059b0
Compare
- An explicit size must be provided ('each' cannot be used).
- This is the opposite of the declaration which must use [:].
Otherwise Dymola tries to check the size at translation and issues a
warning.
…lica-buildings into issue1374_template_CHW_final
…water isolation valve position setpoint output
…lica-buildings into issue1374_template_CHW_final
…lica-buildings into issue1374_template_CHW_final
…lica-buildings into issue1374_template_CHW_final
…lica-buildings into issue1374_template_CHW_final
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR to test CI testing with
test-templates-optimicaandtest-templates-dymola.TODO before merging:
issue2293_chiller_plant_seqis merged into the master, replaceBuildings.Templates.ChilledWaterPlants.Components.Controls.Controller_debugwith the actual controller.Buildings/Resources/Scripts/travis/templates/ChilledWaterPlants.pyand.travis.yml.issue1374_template_CHW_finaluses port placement parameterization for the WSE and CT components.Dependencies